KV lang: Make it easy to copy Builder and Factory and make them all contexts. #6442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
Factory
andKNSpace
a context object, likeClock
andBuilder
so that you can switch them out during testing, so that stuff doesn't leak between tests.Specifically, it adds
create_from
methods for the objects so that we can copy them (e.g. forBuilder
we loadstyle.kv
into the default, so we need to be able to copy the object with its current state).