Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label: Fixes multiline label w/ line_height < 1 #6422

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Label: Fixes multiline label w/ line_height < 1 #6422

merged 1 commit into from
Aug 10, 2019

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Jul 17, 2019

This PR fixes a "rendering" issue that prevents the user from take advantage of the Label line_height property whenline_height is less than 1

I think that needs some tests from devs and users in order to check unexpected behaviors on different devices and configurations.

Testcase example:

BoxLayout:
    size_hint: 1, .5
    Label:
        size_hint: 1, 1
        color: 0, 0, 0, 1
        text_size: self.size
        font_size: dp(13)
        halign: 'left'
        valign: 'top'
        max_lines: 3
        shorten_from: 'right'
        line_height: .7
        padding: 0, 0
        text: "Lorem ipsum dolor sit amet demo demo demo demo"

@matham
Copy link
Member

matham commented Jul 21, 2019

I don't understand the relationship between font_blended and line height being less than 1?

@tshirtman
Copy link
Member

when lines where less than 1, lines would cut each others instead of sharing the overlapping space, this looked bad.

@tshirtman tshirtman merged commit f42fb43 into kivy:master Aug 10, 2019
@tito tito mentioned this pull request Sep 8, 2019
Merged
@misl6 misl6 mentioned this pull request Sep 9, 2019
Closed
@matham matham added this to the 2.0.0 milestone Oct 28, 2020
@matham matham changed the title Fixes multiline label w/ line_height < 1 Label: Fixes multiline label w/ line_height < 1 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshirtman tshirtman tshirtman approved these changes

Assignees
No one assigned
Labels
Component: core-providers kivy/core
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@misl6 @matham @tshirtman