Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core/image]Image: don't force iteration if we reuse the cache #6193

Merged
merged 1 commit into from
Mar 12, 2019
Merged

[core/image]Image: don't force iteration if we reuse the cache #6193

merged 1 commit into from
Mar 12, 2019

Conversation

tito
Copy link
Member

@tito tito commented Mar 12, 2019

The texture will be populated as usual on the first access, no need to force the population through _img_iterate here.

Fixes #6173

@tito
image: don't force iteration if we reuse the cache
1b89bec 
The texture will be populated as usual on the first access, no need to force the population through _img_iterate here.

Fixes #6173
AndreMiras
AndreMiras approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@tito tito merged commit 208a8fd into master Mar 12, 2019
@tito tito deleted the fix-6173 branch March 12, 2019 22:50
@matham matham changed the title Image: don't force iteration if we reuse the cache [core/image]Image: don't force iteration if we reuse the cache May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segfault in core image when loading same image twice
2 participants
@tito @AndreMiras