Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core/window][highlight]Supports live resizing (sdl2 only) #6186

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

tito
Copy link
Member

@tito tito commented Mar 7, 2019

Today, when the window is resized content is black or just partially drawed. This is because poll() is blocked until we release the mouse.
But we can catch the resize event in the event filter. So the idea is to catch and force the window resize, and force drawing. Works like a charm.
Tested on OSX 10.14 with SDL 2.0.5 and retina screen.

Credits goes to @arafangion for the initial code.

Fixes #2844

Today, when the window is resized content is black or just partially
drawed. This is because poll() is blocked until we release the mouse.
But we can catch the resize event in the event filter. So the idea is
to catch and force the window resize, and force drawing.
Works like a charm.
Tested on OSX 10.14 with SDL 2.0.5 and retina screen.

Credits goes to @arafangion for the initial code.

Fixes #2844
@tito tito added this to To do in Mathieu's backlog via automation Mar 7, 2019
@tito tito moved this from To do to Waiting CI in Mathieu's backlog Mar 7, 2019
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍶

@akshayaurora
Copy link
Member

Works like a charm 👍

@akshayaurora akshayaurora merged commit 8f48a11 into master Mar 8, 2019
Mathieu's backlog automation moved this from Waiting CI to Done Mar 8, 2019
@tito tito deleted the fix-2844 branch March 8, 2019 18:42
@matham matham changed the title Supports live resizing (sdl2 only) [core/window][highlight]Supports live resizing (sdl2 only) May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Live window resizing
3 participants