[core/window]window: fix multiple resize sent, and always sent the GL size, never … #6179
Conversation
…the system size, otherwise you'll end up with the size sent twice. Now, because we send the correct size, there is still a code path that make the resize event sent twice. I introduced a pre_resize internal event to debounce it. Fixes #6082
There was a problem hiding this comment.
LGTM ✔️
Just friendly nitpik-reminder about the 50/72 rule https://medium.com/@preslavrachev/what-s-with-the-50-72-rule-8a906f61f09c
For instance github is following it somehow, that's why your title looks messy, since it's being truncated.
So the idea is to to find a meaningful but concise commit title and use the body for the rest
|
How would you rephrase it? The issue explained everything with a runnable example,and I described the way I handled it. I don't think that the message was missing anything, except GH that splitted the title but that's it? |
|
Yes I'm talking about the title split, it's actually a feature that comes fro that 50/72 rule. So I just suggested to be more concise in the title and then put the details you put but in the body (using two new lines). That's the idea, note the empty line after the title. |
|
So it's just because the first line of the commit is too long right? |
|
Yes it's exactly about that too long first line. I should have stated that more clearly 😅 https://stackoverflow.com/questions/2290016/git-commit-messages-50-72-formatting |
matham
changed the title
…the system size, otherwise you'll end up with the size sent twice.
Now, because we send the correct size, there is still a code path that make the resize event sent twice. I introduced a pre_resize internal event to debounce it.
Fixes #6082