replace vendored lib/OSC and lib/oscAPI with oscpy #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 28, 2018
Closed
|
With Python 3.6, i needed to change with to make tuio accepting the messages EDIT: and the condition if cmd not in ['alive', 'set'] with b'' string too |
tito
reviewed
Jun 3, 2018
setup.py
Outdated
| @@ -1103,7 1103,9 @@ def get_extensions_from_sources(sources): | |||
| 'Topic :: Software Development :: User Interfaces'], | |||
| dependency_links=[ | |||
| 'https://github.com/kivy-garden/garden/archive/master.zip'], | |||
| install_requires=['Kivy-Garden>=0.1.4', 'docutils', 'pygments'], | |||
| install_requires=[ | |||
| 'Kivy-Garden>=0.1.4', 'docutils', 'pygments', 'oscpy' | |||
There was a problem hiding this comment.
I wonder if that could be optionnal now? I know you use it in your daily job, just wondering.
There was a problem hiding this comment.
Sure, i guess it would be more convenient for platforms like android/ios where it's not useful.
|
Otherwise 1 for this PR. It saved my week. |
add a info logging at import time if oscpy seems to be missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with tuio on python3, and replace an old hacky vendored lib, with a more modern alternative, that is tested on both python versions, and has good coverage, as well as better performances.
The impact on kivy tuio provider is minimal.