Clean hanging code #5232
Merged
Clean hanging code #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessant
reviewed
Jun 29, 2017
| @@ -13,17 13,6 @@ handlers. | |||
|
|
|||
| __all__ = ('EventDispatcher', 'ObjectWithUid', 'Observable') | |||
|
|
|||
|
|
|||
| cdef extern from "Python.h": | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the default behavior for a Python function is returning a
Noneif not told otherwise, so there's no need for the hangingNone, nor for hangingreturnat the end of some functions it doesn't match the rest of the codebase (eitherreturnorreturn <value>or nothing).The
Python.hextern is from older @matham's code that apparently isn't around (or at least the imported stuff isn't used), ref #2566I'm not sure about the X11 Cython code, because it doesn't import anything from the C code apparently, only makes it required at the compile time I guess? But then the
window_x11_keytab.cisn't required this way, so... That's @tito's code, so I'm not sure about it. ref adb5a85Also, in py2
print()prints a tuple (()), which will break the output (the GLES file) and I've seen it even in thereport.py.