Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/cusomize: support customize parameter by env #24

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

whalecold
Copy link
Member

@whalecold whalecold commented Jan 8, 2024

What type of PR is this?

What this PR does / why we need it (en: English/zh: Chinese):

en:
zh:
支持从环境变量设置参数以下参数:

  • 是否开启 auth
  • token path
  • istiod addr
  • istiod name

Which issue(s) this PR fixes:

@whalecold whalecold changed the title WIP: feat/cusomize: support customize parameter by env feat/cusomize: support customize parameter by env Jan 10, 2024
@ppzqh ppzqh self-assigned this Jan 11, 2024
option.go Outdated Show resolved Hide resolved
Copy link
Member

@CoderPoet CoderPoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CoderPoet, ppzqh, whalecold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CoderPoet CoderPoet merged commit 64bbf75 into kitex-contrib:main Jan 12, 2024
11 checks passed
@whalecold whalecold deleted the feat/customize branch January 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants