Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary code paths during startup #10131

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

pedroigor
Copy link
Contributor

Closes #10130

@pedroigor pedroigor marked this pull request as ready for review February 11, 2022 11:42
Copy link
Contributor

@DGuhr DGuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedroigor LGTM, so approved, but can you pls doublecheck if the failing cross-dc tests are somewhat related to your changes? I guess not, but not sure.

Tested:

  1. improvement of startup time ("pragmatic" performance test on my machine):
  • executed: repeat 10 { command time -p ./kc.sh -Dkc.launch.mode=test start-dev }
  • result: times were between 3.2s and 3.5s after initial db creation, more to the 3.2 side, best was 3.251ms to startup. So yes, makes it faster :) before it was more ~3.4 to 3.7
  1. See if caches still work due to dependency change
  • Checked with a singleDC deployment with external ispn 12. Worked as expected. I assume you checked the usual cachingscenario on your side after changing the dependencies.

@pedroigor
Copy link
Contributor Author

@DGuhr Thanks. Yes, the clustering tests should be covering these changes. Mainly when using a custom jgroups stack.

@stianst stianst merged commit f3c3bb5 into keycloak:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing unnecessary code paths during startup
3 participants