Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs : update README.md #571

Closed
wants to merge 1 commit into from
Closed

docs : update README.md #571

wants to merge 1 commit into from

Conversation

GoogTech
Copy link

@GoogTech GoogTech commented Oct 1, 2020

Description

add the step description about how to install this icon theme bro.

docs : update README.md
a516845 
add the step description about how to install this icon theme bro.
@keeferrourke
Copy link
Owner

I'm on board with parts of this change, however this PR has some issues.

  1. The new section duplicates some information which is available at the top of the README.
  2. Your tweak tool and gsettings specific instructions are incorrect and unfriendly for users of desktop environments that aren't based on GNOME/GTK. This project tries to support at least GNOME and KDE with the goal of DE ambivalence. If you want to include this information, then information for other envs also needs to be included.

keeferrourke
keeferrourke requested changes Oct 2, 2020
View reviewed changes
README.md
gsettings set org.gnome.desktop.interface icon-theme "la-capitaine-icon-theme"
```

3. Thats it you're done!
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is hella confusing considering the section that immediately follows is entitled "configuration". If that was it, there'd be nothing to configure!

Copy link
Author

@GoogTech GoogTech Oct 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

gsettings set org.gnome.desktop.interface icon-theme "la-capitaine-icon-theme"

wow, sorry bro because I'm a beginner of kali linux.
but the feature of above command is same as select this theme in tweak tool and I tested.

@GoogTech GoogTech closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keeferrourke keeferrourke keeferrourke requested changes

Assignees
No one assigned
Labels
needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoogTech @keeferrourke