Fix a CoreData multithreading issue in LoggerStore.info()
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The store info is constructed using a background task. The background task constructs its own context that needs to be used throughout the task
|
Great catch, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoggerStore.info()usesNSPersistentContainer.performBackgroundTaskto construct the info. The background task constructs has its nowNSManagedObjectContextthat must be used throughout the task.However
getBlobsSize()was using a differentbackgroundContextto fetch the sum of the blob size. This mismatch of contexts causes a CoreData multithreading assertion to be triggered.This PR addresses this issue by supplying the correct
NSManagedObjectContextto use withingetBlobsSize()