Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tzinfo 2 0 #4

Merged
merged 9 commits into from
Jun 12, 2024
Merged

fix tzinfo 2 0 #4

merged 9 commits into from
Jun 12, 2024

Conversation

LeipeLeon
Copy link
Member

Fixes the error:

undefined method `utc_start' for TZInfo::TransitionsTimezonePeriod

and makes it rails 6.1 compatible

Note

Including #2 because of failing specs

@LeipeLeon LeipeLeon mentioned this pull request Jun 11, 2024
Closed
@LeipeLeon
Copy link
Member Author

note: just disabled codeship Commit Status Reporting although that failing spec is still listed.

@kjwierenga
Copy link
Member

Deleted ri_cal project from CodeShip.

kjwierenga
kjwierenga approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@kjwierenga kjwierenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice to see that planningcenter.com engineers are using ri_cal too and pitching in with this fix :-)

@LeipeLeon LeipeLeon merged commit c28d6ce into develop Jun 12, 2024
18 of 19 checks passed
@LeipeLeon LeipeLeon deleted the feature/tzinfo_2_0 branch June 12, 2024 14:17
LeipeLeon added a commit that referenced this pull request Jun 13, 2024
@LeipeLeon
Release 0.10.0
c44f806 
## 🚨 BREAKING

- Add support for `tzinfo 2.X`
- Drop support for `tzinfo 1.X`

## Other changes
- Merge pull request #4 from kdgm/feature/tzinfo_2_0
- Merge pull request #1 from dustacio/bugfix_for_ambiguous_local_time
- Merge branch 'hotfix/0.9.1'
LeipeLeon added a commit that referenced this pull request Jun 13, 2024
@LeipeLeon
Merge tag '0.10.0' into develop
6168ef1 
- Add support for `tzinfo 2.X`
- Drop support for `tzinfo 1.X`

- Merge pull request #4 from kdgm/feature/tzinfo_2_0
- Merge pull request #1 from dustacio/bugfix_for_ambiguous_local_time
- Merge branch 'hotfix/0.9.1'

* tag '0.10.0':
  Release 0.10.0
  Bugfix for Ambiguous Local Time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjwierenga kjwierenga kjwierenga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@LeipeLeon @kjwierenga @phoet @jkraemer