Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kustomize replacements when creating custom-manifest #325

Open
mathe-matician opened this issue Dec 29, 2023 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@mathe-matician
Copy link

Right now there doesn't seem to be support for using replacements when creating custom-manifest.

@pst pst added the enhancement New feature or request label Dec 29, 2023
@pst
Copy link
Member

pst commented Dec 29, 2023

Thanks for the suggestion. Here's big picture what needs to be done for anyone interested to pick this up:

First needs support in the provider here: https://github.com/kbst/terraform-provider-kustomization
Then the variable can be exposed in the module here: https://github.com/kbst/catalog/tree/master/src/_terraform_module

@mathe-matician
Copy link
Author

mathe-matician commented Dec 30, 2023

@pst

First needs support in the provider here

To clarify, isn't it already supported in the repo here? https://github.com/kbst/terraform-provider-kustomization/blob/c75a675049a3c88b285dc53600ac7d5b380d5f72/kustomize/data_source_kustomization_overlay.go#L338

So it would just need to be exposed in the custom-manifest module?

Edit:

I would love to pick this issue up too regardless. Let me know if that is possible.

@pst
Copy link
Member

pst commented Jan 3, 2024

You are right, replacements seem to already be supported in the provider. I guess I lost track myself.

@mathe-matician
Copy link
Author

@pst no worries - I'm still willing to contribute to the second part you mentioned above:

Then the variable can be exposed in the module here: https://github.com/kbst/catalog/tree/master/src/_terraform_module

@pst
Copy link
Member

pst commented Jan 4, 2024

Happy to review your contribution whenever you get around to it.

If you add the variable to the .tf files in src/_terraform_module the changes will automatically be included in all future module versions built. That includes both the ones that bundle upstream like nginx or cert-manager, but also the custom-manifests module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants