Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/k8s: Add uninstall kbs client command function #9461

Merged
merged 1 commit into from
Apr 17, 2024
Merged

tests/k8s: Add uninstall kbs client command function #9461

merged 1 commit into from
Apr 17, 2024

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Apr 11, 2024

This PR adds the function to uninstall kbs client command function specially when we are running with baremetal devices.

Fixes #9460

@GabyCT
tests/k8s: Add uninstall kbs client command function
5420595 
This PR adds the function to uninstall kbs client command function
specially when we are running with baremetal devices.

Fixes kata-containers#9460

Signed-off-by: Gabriela Cervantes <[email protected]>
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Apr 11, 2024
@GabyCT
Copy link
Contributor Author

GabyCT commented Apr 11, 2024

So I tried that in a local environment and seems working

tdxtest@tdxtest:/tmp/trustee/kbs$ sudo make uninstall
rm -rf /usr/local/bin/kbs /usr/local/bin/kbs-client /usr/local/bin/issuer-kbs /usr/local/bin/resource-kbs

@GabyCT GabyCT added the area/confidential-containers Issues related to confidential containers (see also CCv0 branch) label Apr 11, 2024
@GabyCT GabyCT mentioned this pull request Apr 11, 2024
Merged
wainersm
wainersm approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to delete more binaries than kbs-client but It seems not to harm anything. LGTM. Thanks @GabyCT !

@GabyCT
Copy link
Contributor Author

GabyCT commented Apr 11, 2024 •
edited
Loading

This is going to delete more binaries than kbs-client but It seems not to harm anything. LGTM. Thanks @GabyCT !

@wainersm yes the other option is to do sudo rm /usr/local/bin/kbs-client but I prefer to have the first one to have a clean clean environment specially on baremetal

@wainersm
Copy link
Contributor

This is going to delete more binaries than kbs-client but It seems not to harm anything. LGTM. Thanks @GabyCT !

@wainersm yes the other option is to do sudo rm /usr/local/bin/kbs-client but I prefer to have the first one to have a clean clean environment specially on baremetal

That"s fine to me @GabyCT !

@wainersm
Copy link
Contributor

/test

1 similar comment
@wainersm
Copy link
Contributor

/test

@wainersm wainersm merged commit 2d8e793 into kata-containers:main Apr 17, 2024
306 of 314 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmihai1 danmihai1 danmihai1 approved these changes

@wainersm wainersm wainersm approved these changes

Assignees
No one assigned
Labels
area/confidential-containers Issues related to confidential containers (see also CCv0 branch) ok-to-test size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests/k8s: add uninstall kbs client command function
4 participants
@GabyCT @wainersm @danmihai1 @katacontainersbot