tests: Improve the kbs_k8s_delete function #9423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wainersm besides the pod, do you want me to verify the deployment and the configmaps? |
GabyCT
changed the title
|
Hi @GabyCT ! Hey, thanks for working on it!
Notice that currently we only have support for the AKS ingress, but after the merge of #9273 we will have the nodeport too. The AKS"s ingress will install daemonsets too IIRC and we will need to check they were over. The nodeport ingress model will only deploy a service which I don"t believe we should check it is deleted. |
GabyCT
added
area/confidential-containers
dborquez
approved these changes
Apr 8, 2024
GabyCT
force-pushed
the
topic/improvecleanup
branch
from
42ab710 to
f5d1695
Compare
GabyCT
changed the title
GabyCT
force-pushed
the
topic/improvecleanup
branch
from
f5d1695 to
fb4c359
Compare
This PR improves the kbs_k8s_delete function to verify that the resources were properly deleted for baremetal environments. Fixes kata-containers#9379 Signed-off-by: Gabriela Cervantes <[email protected]>
|
@wainersm I tested this PR on a baremetal environment and seems working as it verifies the nodeport and aks After running the PR, I verify that both nodeport and aks was gone on the baremetal |
danmihai1
approved these changes
Apr 10, 2024
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the kbs_k8s_delete function to verify that the resources were properly deleted for baremetal environments.
Fixes #9379