Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: resurrect travis static checkers #811

Merged
merged 7 commits into from
Sep 28, 2020

Conversation

bergwolf
Copy link
Member

Somehow travis was not running static checkers and it silently reports success. It resulted in a lot of static check failures. Let"s resurrect it and fix the static check errors.

@bergwolf
Copy link
Member Author

/test-ubuntu

@bergwolf bergwolf force-pushed the runtime-check branch 5 times, most recently from ec64651 to a9a0fec Compare September 27, 2020 15:00
@bergwolf
Copy link
Member Author

/test

Copy link
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bergwolf bergwolf force-pushed the runtime-check branch 3 times, most recently from ab3d1f5 to 2105d8c Compare September 28, 2020 02:12
Need to use the correct script path.

Fixes: kata-containers#802
Signed-off-by: Peng Tao <[email protected]>
@bergwolf bergwolf force-pushed the runtime-check branch 2 times, most recently from 9909155 to e9aef90 Compare September 28, 2020 02:27
@bergwolf
Copy link
Member Author

/test-ubuntu

@bergwolf bergwolf force-pushed the runtime-check branch 2 times, most recently from 5f6abe2 to bf0bf66 Compare September 28, 2020 02:49
Somehow we are not running static checks for a long time.
And that ended up with a lot for errors.

* Ensure debug options are valid is dropped
* fix snap links
* drop extra CONTRIBUTING.md
* reference kata-pkgsync
* move CODEOWNERS to proper place
* remove extra CODE_OF_CONDUCT.md.
* fix spell checker error on Developer-Guide.md

Signed-off-by: Peng Tao <[email protected]>
We use 2.0-dev in the tests repository now. Always make sure
we use the right branch.

Signed-off-by: Peng Tao <[email protected]>
Otherwise travis fails.

Signed-off-by: Peng Tao <[email protected]>
Need to run gofmt -s on them.

Signed-off-by: Peng Tao <[email protected]>
As we have already run it on x64.

Signed-off-by: Peng Tao <[email protected]>
It needs root.

Signed-off-by: Peng Tao <[email protected]>
@bergwolf
Copy link
Member Author

/test-ubuntu

@bergwolf
Copy link
Member Author

/test-clh

@liubin liubin merged commit 46f420a into kata-containers:2.0-dev Sep 28, 2020
@fidencio fidencio mentioned this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants