-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: resurrect travis static checkers #811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test-ubuntu |
bergwolf
force-pushed
the
runtime-check
branch
5 times, most recently
from
September 27, 2020 15:00
ec64651
to
a9a0fec
Compare
/test |
fidencio
approved these changes
Sep 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
liubin
approved these changes
Sep 28, 2020
bergwolf
force-pushed
the
runtime-check
branch
3 times, most recently
from
September 28, 2020 02:12
ab3d1f5
to
2105d8c
Compare
Need to use the correct script path. Fixes: kata-containers#802 Signed-off-by: Peng Tao <[email protected]>
bergwolf
force-pushed
the
runtime-check
branch
2 times, most recently
from
September 28, 2020 02:27
9909155
to
e9aef90
Compare
/test-ubuntu |
bergwolf
force-pushed
the
runtime-check
branch
2 times, most recently
from
September 28, 2020 02:49
5f6abe2
to
bf0bf66
Compare
Somehow we are not running static checks for a long time. And that ended up with a lot for errors. * Ensure debug options are valid is dropped * fix snap links * drop extra CONTRIBUTING.md * reference kata-pkgsync * move CODEOWNERS to proper place * remove extra CODE_OF_CONDUCT.md. * fix spell checker error on Developer-Guide.md Signed-off-by: Peng Tao <[email protected]>
We use 2.0-dev in the tests repository now. Always make sure we use the right branch. Signed-off-by: Peng Tao <[email protected]>
Otherwise travis fails. Signed-off-by: Peng Tao <[email protected]>
Need to run gofmt -s on them. Signed-off-by: Peng Tao <[email protected]>
As we have already run it on x64. Signed-off-by: Peng Tao <[email protected]>
It needs root. Signed-off-by: Peng Tao <[email protected]>
bergwolf
force-pushed
the
runtime-check
branch
from
September 28, 2020 03:03
bf0bf66
to
85d2230
Compare
/test-ubuntu |
/test-clh |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow travis was not running static checkers and it silently reports success. It resulted in a lot of static check failures. Let"s resurrect it and fix the static check errors.