-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Port kata-monitor tests from Jenkins to GHA #8075
Merged
fidencio
merged 6 commits into
kata-containers:main
from
fidencio:topic/ci-add-kata-monitor-tests
Sep 27, 2023
Merged
ci: Port kata-monitor tests from Jenkins to GHA #8075
fidencio
merged 6 commits into
kata-containers:main
from
fidencio:topic/ci-add-kata-monitor-tests
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's ensure we have runc running with `SystemdCgroups = false`, otherwise we'll face failures when running tests depending on runc on Ubuntu 22.04, woth LTS containerd. Signed-off-by: Fabiano Fidêncio <[email protected]>
This will become handy when doing tests with CRI-O, as CRI-O doesn't install the CNI plugins for us. Signed-off-by: Fabiano Fidêncio <[email protected]>
This will serve us quite will in the upcoming tests addition, which will also have to be executed using CRi-O. Signed-off-by: Fabiano Fidêncio <[email protected]>
This will help us when running tests using CRI-O. Signed-off-by: Fabiano Fidêncio <[email protected]>
The kata-monitor tests is currently running as part of the Jenkins CI with the following setups: * Container Engines: CRI-O | containerd * VMMs: QEMU When using containerd, we're testing it with: * Snapshotter: overlayfs | devmapper We will stop running those tests on devmapper / overlayfs as that hardly would get us a functionality issue. Also, we're restricting this to run with the LTS version of containerd, when containerd is used. As it's known due to our GHA limitation, this is just a placeholder and the tests will actually be added in the next iterations. Signed-off-by: Fabiano Fidêncio <[email protected]>
Let's move, adapt, and use the kata-monitor tests from the tests repo. In this PR I'm keeping the SoB from every single contributor from who touched those tests in the past. Fixes: kata-containers#8074 Signed-off-by: Fabiano Fidêncio <[email protected]> Signed-off-by: yaoyinnan <[email protected]> Signed-off-by: Gabriela Cervantes <[email protected]> Signed-off-by: James O. D. Hunt <[email protected]>
katacontainersbot
added
the
size/huge
Largest and most complex task (probably needs breaking into small pieces)
label
Sep 27, 2023
fidencio
added
force-skip-ci
Stop the CI running for a PR (remember: if you break it, you fix it!)
ok-to-test
labels
Sep 27, 2023
stevenhorsman
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
/test |
GabyCT
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
force-skip-ci
Stop the CI running for a PR (remember: if you break it, you fix it!)
ok-to-test
size/huge
Largest and most complex task (probably needs breaking into small pieces)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in the kata-monitor tests.
The tests I've performed locally can be seen here:
I've performed the tests on an ubuntu 22.04 VM, matching the "smaller" garm VM, and I've used the kata-static tarball generated from Yesterday's nightly run.