Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: Call s.newStore.Destroy if globalSandboxList.addSandbox #697

Merged
merged 1 commit into from
Sep 27, 2020
Merged

runtime: Call s.newStore.Destroy if globalSandboxList.addSandbox #697

merged 1 commit into from
Sep 27, 2020

Conversation

keloyang
Copy link
Contributor

@keloyang keloyang commented Sep 9, 2020 •
edited
Loading

Fixes: #696

backport from kata-containers/runtime#2920

Signed-off-by: Shukui Yang [email protected]

@amshinde
Copy link
Member

amshinde commented Sep 9, 2020

@keloyang Can you change the commit message to include "Fixes: #696", basically add a "#" before the issue number.

@jodh-intel
Copy link
Contributor

Thanks @keloyang. However Travis is failing due to your "fixes" line - you need a # before the number:

Fixes: #696

jensfr
jensfr approved these changes Sep 15, 2020
View reviewed changes
Copy link

@jensfr jensfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel jodh-intel added the forward-port Change from an older branch / repository label Sep 15, 2020
jodh-intel
jodh-intel approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keloyang.

lgtm

@devimc
Copy link

devimc commented Sep 21, 2020

Thanks but CI is not happy

ERROR: No "Fixes" found
ERROR: checkcommits failed. See the document below for help on formatting
commits for the project.

@bergwolf
Copy link
Member

/retest

@bergwolf bergwolf merged commit ac6f020 into kata-containers:2.0-dev Sep 27, 2020
@jodh-intel jodh-intel mentioned this pull request Nov 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodh-intel jodh-intel jodh-intel approved these changes

@amshinde amshinde amshinde approved these changes

@jensfr jensfr jensfr approved these changes

@bergwolf bergwolf bergwolf approved these changes

Assignees
No one assigned
Labels
forward-port Change from an older branch / repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forget to clean up for s.newStore
6 participants
@keloyang @amshinde @jodh-intel @devimc @bergwolf @jensfr