tools/snap: simplify nproc #4533
Conversation
|
/test |
|
Please DO care about the result for s390x. Thanks. (updated) |
|
I found that this change breaks a CI job for s390x, which has the connection to the slave instance lost during the test. I tried the test 4 times over 3 different machines, but no success and the same failures. I have just confirmed that this does not happen with the main branch. Please see the log: http://jenkins.katacontainers.io/job/kata-containers-2.0-ubuntu-s390x-PR/1963/ Question: I was even not able to ssh into the slave instance after the failure. Any guess? ^^ |
Replaces calls of nproc with nproc with
nproc ${CI: --ignore 1}
to run nproc with one less processing unit than the maximum to prevent
DOS-ing the local machine.
If process is being run in a container (determined via whether $CI is
null), all processing units avaliable will be used.
Fixes kata-containers#3967
Signed-off-by: Derek Lee <[email protected]>
bookinabox
force-pushed
the
simplify-nproc
branch
from
a655e58 to
0e40ecf
Compare
|
Not too familiar with how most things work still, but I did notice problem in my code after looking at it again. I left an extra $() in the snapcraft.yaml. I fixed that, so hopefully it'll work. I don't think I'm able to re-run the jenkins job. Is there a better way for me to test by myself? |
|
/test |
|
/test-arm |
Replaces calls of nproc with nproc with
nproc ${CI: --ignore 1}
to run nproc with one less processing unit than the maximum to prevent
DOS-ing the local machine.
If process is being run in a container (determined via whether $CI is
null), all processing units avaliable will be used.
Fixes #3967
Signed-off-by: Derek Lee [email protected]