Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: add connection infos and uptime to getInfo #2095

Open
wants to merge 17 commits into
base: dev
Choose a base branch
from

Conversation

D-Stacks
Copy link
Contributor

@D-Stacks D-Stacks commented Jun 19, 2022

This closes #2012, at least from what is written in the title, perhaps a getStats is required in addition.

@D-Stacks D-Stacks changed the base branch from master to dev June 19, 2022 09:15
@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #2095 (7ccd90c) into dev (14b2bcb) will decrease coverage by 2.39%.
The diff coverage is 47.22%.

@@            Coverage Diff             @@
##              dev    #2095       /-   ##
==========================================
- Coverage   61.60%   59.20%   -2.40%     
==========================================
  Files         627      679       52     
  Lines       29502    32966     3464     
==========================================
  Hits        18176    19519     1343     
- Misses       8751    10620     1869     
- Partials     2575     2827      252     
Impacted Files Coverage Δ
app/app.go 0.00% <0.00%> (ø)
app/appmessage/error.go 0.00% <0.00%> (ø)
app/appmessage/message.go 71.42% <ø> (ø)
app/appmessage/p2p_msgrequestanticone.go 0.00% <0.00%> (ø)
..._msgrequestnextpruningpointanditsanticoneblocks.go 0.00% <0.00%> (ø)
app/appmessage/protocol.go 100.00% <ø> (ø)
app/appmessage/rpc_get_balances_by_addresses.go 0.00% <0.00%> (ø)
app/appmessage/rpc_get_mempool_entries.go 0.00% <0.00%> (ø)
app/appmessage/rpc_submit_block.go 83.33% <ø> (ø)
app/protocol/flowcontext/errors.go 26.66% <0.00%> (-13.34%) ⬇️
... and 288 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@D-Stacks D-Stacks closed this Jul 2, 2022
@D-Stacks D-Stacks reopened this Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the "uptime" parameter to a GetInfo request
1 participant