[htmx] Credential Update page #2897
Conversation
Defer implementation to blank_iff Co-authored-by: James Hodgkinson <[email protected]>
server/core/templates/cred_update/add_password_modal_partial.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This is a good start, but remember just because we did it before with modals and js like this doesn't mean we need to stick to this pattern now. I think you're trying to keep it too "the same" when you have the opportunity to approach things differently. For example, we could avoid modals and do something more like what github does or have inline forms, or we could even use htmx a bit more to avoid the js. Don't be limited by what we already have!
…il to set a group policy so its not tested)
|
Would be great if someone could test out the attested passkeys ui, remove totp needs to be reworked I think |
|
I'll test it for you during the week :) |
|
Seems to work:
Only things are that there is a trailing slash that shouldn't be there, and the "name this passkey" should be autofocused already, and should accept "enter" key to submit the form. Otherwise works well! |
|
@yaleman what do you think? @ToxicMushroom Just needs a rebase is the main thing |
|
Looks great so far! |
Co-authored-by: James Hodgkinson <[email protected]>
|
Also needs a rebase to master :) |
|
@yaleman Up to you now :) |
Contains credential reset form, update page with (passkeys, attested passkeys, totp, password)
Checklist