Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing import / export diagnostics #182

Closed
kaleidawave opened this issue Aug 6, 2024 · 1 comment · Fixed by #192
Closed

Add missing import / export diagnostics #182

kaleidawave opened this issue Aug 6, 2024 · 1 comment · Fixed by #192
Labels
diagnostics related to outputting code errors good-first-issue PRs welcome 🙏

Comments

@kaleidawave
Copy link
Owner

There are a few missing diagnostics for some things related to imports/exports

  • export in invalid location
  • exporting same name
  • Some others that have todo! in features/modules.rs

Would be good to get these wired up similar to other diagnostics

Some of these might be built into the parser at some point
@kaleidawave kaleidawave added good-first-issue PRs welcome 🙏 diagnostics related to outputting code errors labels Aug 6, 2024
@NitantP NitantP mentioned this issue Aug 17, 2024
Merged
@NitantP
Copy link
Contributor

NitantP commented Aug 17, 2024

Hi, @kaleidawave! I took a stab at this in #192, but could use some direction as I'm still learning the codebase.

@kaleidawave kaleidawave linked a pull request Aug 19, 2024 that will close this issue
Add "duplicate import name" and "missing default export" diagnostics #192
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diagnostics related to outputting code errors good-first-issue PRs welcome 🙏
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add "duplicate import name" and "missing default export" diagnostics NitantP/ezno
2 participants
@NitantP @kaleidawave