Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that server-side apply is necessary for the CRDs #987

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Document that server-side apply is necessary for the CRDs #987

merged 1 commit into from
Jul 24, 2024

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Jul 23, 2024 •
edited
Loading

Summary

Because the CRDs have grown quite a bit, it's now necessary to apply then with the server side flag.

Checklist

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Commits are signed off
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@Kidswiss Kidswiss added documentation This issue or pull request affects documentation area:chart chart:k8up labels Jul 23, 2024
@Kidswiss Kidswiss requested a review from a team as a code owner July 23, 2024 12:50
@Kidswiss Kidswiss requested review from tobru, wejdross, TheBigLee and zugao and removed request for a team July 23, 2024 12:50
@Kidswiss Kidswiss force-pushed the fix/server-side-apply branch 3 times, most recently from af219e8 to 9e3a6c8 Compare July 23, 2024 12:53
zugao
zugao approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kidswiss Kidswiss merged commit 1426f00 into master Jul 24, 2024
8 checks passed
@Kidswiss Kidswiss deleted the fix/server-side-apply branch July 24, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@tobru tobru tobru approved these changes

@wejdross wejdross Awaiting requested review from wejdross wejdross is a code owner automatically assigned from k8up-io/maintainer

@TheBigLee TheBigLee Awaiting requested review from TheBigLee

Assignees
No one assigned
Labels
area:chart chart:k8up documentation This issue or pull request affects documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kidswiss @tobru @zugao