Prompting errors when it fails to load. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HassanAli66
changed the title
jurem
requested changes
Oct 26, 2022
There was a problem hiding this comment.
Thanks for your contribution. Nevertheless, we still want to fully support command line usage of assembler, so don"t want to have any windows being popped up in text mode. Special handling should be made for GUI and TUI mode.
Additionally, print relates to printing not constructing string. String construction should be refactored in a separate function. Finally, the call to this new function in loadAsm() should be made only once (the same string construction is currently performed twice). I would also suggest use of StringBuilder instead of String.
|
For the other contribution - title change is unnecessary. All contributors are acknowledged through github dashboard, git log etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the inconvenience of the Error handling process of SicTools. I"ve made some modifications that prompts all errors found in a .asm file when the simulator fails to load the file other than just printing those errors in a command line. because, sometimes windows users for example run the simulator from just double clicking on sic.jar file. so, they can"t see the errors when they have ones because there is no cmd or a terminal running to show these errors.