Ensure all slash commands support -h/--help
#878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
requested changes
Jul 8, 2024
There was a problem hiding this comment.
@krassowski Thank you for opening this PR to improve help in slash commands! Left some feedback below.
dlqqq
changed the title
dlqqq
requested changes
Jul 8, 2024
dlqqq
changed the title
-h/--help
|
@krassowski I'm marking this as a draft for now as you work on addressing the feedback above. Feel free to mark this as ready & ping me when done, thanks! 👋 |
|
I applied the requested changes:
|
dlqqq
added
enhancement
dlqqq
requested changes
Jul 9, 2024
There was a problem hiding this comment.
@krassowski Almost there! One minor naming suggestion below.
Co-authored-by: david qiu <[email protected]>
Co-authored-by: david qiu <[email protected]>
by default the `/help` and "default" handlers opt-out from `-h` handling
dlqqq
approved these changes
Jul 9, 2024
Closed
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Fix help for slash commands * Do not add `-h` to the help command itself Co-authored-by: david qiu <[email protected]> * Fix typo Co-authored-by: david qiu <[email protected]> * Centralize handling of `-h`/`--help`, with opt-out via class attribute by default the `/help` and "default" handlers opt-out from `-h` handling * Add colon delimiter and wrap the arguments in backticks * Use Title case for help messages * Remove final leftover * Rename `display_arguments_help` to `supports_help` --------- Co-authored-by: david qiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #798
I think this is a good first step, explaining
/learn -hoptions and preventing destructive action on/clear -h.