-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed /export
for timestamp, agent name
#854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) Added seconds to the end of the timestamp/ (2) If user provides a filename, we do not use the timestamp (3) If user does not provide a filename, we use "chat_history" timestamp (4) Make sure the correct Agent name is used in the exported output.
for more information, see https://pre-commit.ci
JasonWeill
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good! I tested your changes locally. Just a couple non-functional change suggestions.
Based on comments from Jason Weill
…ter-ai into export_chat_timestamp
Co-authored-by: Jason Weill <93281816 [email protected]>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Enhanced `/export` for timestamp, agent name (1) Added seconds to the end of the timestamp/ (2) If user provides a filename, we do not use the timestamp (3) If user does not provide a filename, we use "chat_history" timestamp (4) Make sure the correct Agent name is used in the exported output. * update docs for export * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Amended export Based on comments from Jason Weill * Update docs/source/users/index.md Co-authored-by: Jason Weill <93281816 [email protected]> --------- Co-authored-by: pre-commit-ci[bot] <66853113 pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jason Weill <93281816 [email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #852
Fixes #853
(1) Added seconds to the end of the filename with timestamp.
(2) If user provides a filename, we do not use the timestamp. This will allow the user to avoid using the timestamp if required.
(3) If user does not provide a filename, we use "chat_history" timestamp, as shown above.
(4) Make sure the correct Agent name is used in the exported output.
(5) Updated the docs page for the
/export
command.