Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed /export for timestamp, agent name #854

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

srdas
Copy link
Collaborator

@srdas srdas commented Jun 21, 2024

Fixes #852

Fixes #853

(1) Added seconds to the end of the filename with timestamp.
image

(2) If user provides a filename, we do not use the timestamp. This will allow the user to avoid using the timestamp if required.
image

(3) If user does not provide a filename, we use "chat_history" timestamp, as shown above.

(4) Make sure the correct Agent name is used in the exported output.
image

(5) Updated the docs page for the /export command.

srdas added 2 commits June 21, 2024 12:35
(1) Added seconds to the end of the timestamp/

(2) If user provides a filename, we do not use the timestamp

(3) If user does not provide a filename, we use "chat_history" timestamp

(4) Make sure the correct Agent name is used in the exported output.
@srdas srdas added the bug Something isn't working label Jun 21, 2024
@srdas srdas self-assigned this Jun 21, 2024
Copy link
Collaborator

@JasonWeill JasonWeill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good! I tested your changes locally. Just a couple non-functional change suggestions.

packages/jupyter-ai/jupyter_ai/chat_handlers/export.py Outdated Show resolved Hide resolved
docs/source/users/index.md Outdated Show resolved Hide resolved
srdas and others added 3 commits June 21, 2024 16:27
Based on comments from Jason Weill
Co-authored-by: Jason Weill <93281816 [email protected]>
@srdas srdas merged commit 387e5b7 into jupyterlab:main Jun 21, 2024
8 checks passed
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
* Enhanced `/export` for timestamp, agent name

(1) Added seconds to the end of the timestamp/

(2) If user provides a filename, we do not use the timestamp

(3) If user does not provide a filename, we use "chat_history" timestamp

(4) Make sure the correct Agent name is used in the exported output.

* update docs for export

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Amended export

Based on comments from Jason Weill

* Update docs/source/users/index.md

Co-authored-by: Jason Weill <93281816 [email protected]>

---------

Co-authored-by: pre-commit-ci[bot] <66853113 pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jason Weill <93281816 [email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants