Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements contributors doc #1045

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Update requirements contributors doc #1045

merged 1 commit into from
Oct 21, 2024

Conversation

JasonWeill
Copy link
Collaborator

Copy edits, relaxes recommendation to use Node 18, which is now in maintenance mode, with an EOL of 2025-04-30. Also removes mention of JupyterLab 3.x, because Jupyter AI 1.x is no longer maintained.

@JasonWeill JasonWeill added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 21, 2024
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this is a two-way door decision. We will rework the documentation later during development of the next major release (v3). I'll elaborate on this once I open a pinned issue discussing the v3 development project.

Copy edits, relaxes recommendation to use Node 18, which is now in maintenance mode, with an EOL of 2025-04-30.
@dlqqq dlqqq force-pushed the JasonWeill-patch-1 branch from b8924d1 to f079f4a Compare October 21, 2024 22:15
@dlqqq dlqqq enabled auto-merge (squash) October 21, 2024 22:16
@dlqqq dlqqq merged commit ca3f2c9 into main Oct 21, 2024
11 checks passed
@jtpio jtpio deleted the JasonWeill-patch-1 branch October 22, 2024 06:31
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
Copy edits, relaxes recommendation to use Node 18, which is now in maintenance mode, with an EOL of 2025-04-30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants