Remove ipython_genutils as a dependency
#586
Conversation
There was a problem hiding this comment.
Thanks @Carreau for your help with this! Some minor comments, the rest looks good to me.
ccordoba12
changed the title
ccordoba12
changed the title
ipython_genutils
I agree with that. Could you do it in this PR as well? |
|
yes I can do that early next week.
…On Sat, Sep 30, 2023 at 17:07 Carlos Cordoba ***@***.***> wrote:
So if you are willing to remove support for html export with non-inline
html, then you can drop ipython_genutils dependency.
I agree with that. Could you do it in this PR as well?
—
Reply to this email directly, view it on GitHub
<#586 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACR5TYWJJZR5WUVTAQAAB3X5AYTJANCNFSM6AAAAAA5M5VXWA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Great! Thanks @Carreau! |
Co-authored-by: Carlos Cordoba <[email protected]>
|
Going through my list of opened PRs, is there anything more I can do here ? Thanks ! |
I think this is still unaddressed. I mean, I thought you were going to remove our dependency on |
|
Oh, yeah sorry, I forgot to remove the lines in setup.py and environment.yml, sorry, oversight. For html export i was wrong about export_html(,.... inline=...) being unused, so I vendored _ensure_dir_exists. Though the dependency should now be gone. |
ccordoba12
changed the title
ipython_genutilsipython_genutils as a dependency
|
Thanks !
…On Thu, Oct 19, 2023 at 16:46 Carlos Cordoba ***@***.***> wrote:
Merged #586 <#586> into master.
—
Reply to this email directly, view it on GitHub
<#586 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACR5TZUB53ZTSK5HVA6JWTYAE4MLAVCNFSM6AAAAAA5M5VXWCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQG4YTGMJYGI2TQMY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This vendors the code.
There is still 1 place using ipython_genutils (ensure_dir_exists), but basically it is only called if you callexport_html(..., inline=False), which I can't find anywhere. So if you are willing to remove support for html export with non-inline html, then you can drop ipython_genutils dependency.