Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast images width and height to int when trying to insert them #570

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Cast images width and height to int when trying to insert them #570

merged 2 commits into from
Mar 6, 2023

Conversation

ccordoba12
Copy link
Collaborator

@ccordoba12 ccordoba12 added this to the 5.4.1 milestone Mar 6, 2023
@ccordoba12
Copy link
Collaborator Author

@blink1073, could you restore regular merges for this repo? I don't like squash-merges because they make harder to detect regressions with git blame.

@blink1073
Copy link
Contributor

Done, and I made you an admin for the repo.

@ccordoba12
Copy link
Collaborator Author

Thanks @blink1073!

@ccordoba12
Testing: Fix tests on Linux and cancel previous builds
569c250 
Also, don't stop on the first test that fails.
@ccordoba12 ccordoba12 self-assigned this Mar 6, 2023
@ccordoba12 ccordoba12 merged commit 96604f4 into jupyter:master Mar 6, 2023
@ccordoba12 ccordoba12 deleted the another-int-cast-error branch March 6, 2023 17:11
This was referenced Mar 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ccordoba12 ccordoba12

Labels
None yet
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ccordoba12 @blink1073