Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI escapes #97

Open
ivanov opened this issue Jul 22, 2013 · 6 comments
Open

ANSI escapes #97

ivanov opened this issue Jul 22, 2013 · 6 comments
Labels
tag:Sprint Friendly A good issue to tackle during a sprint, hackathon, etc. type:Bug An unexpected behavior

Comments

@ivanov
Copy link
Member

ivanov commented Jul 22, 2013

these were added in ipython 1.0, but not yet working in nbviewer:

http://nbviewer.ipython.org/urls/raw.github.com/ipython/ipython/master/examples/tests/ANSI%20Test.ipynb

@rgbkrk
Copy link
Member

rgbkrk commented Dec 19, 2013

Well that's interesting. It works in the notebook but not in nbviewer.

@minrk
Copy link
Member

minrk commented Dec 19, 2013

Yup - ANSI escapes are handled in javascript, which would need to be reimplemented in Python for nbconvert (or more javascript added to the nbconvert output). This is not really an nbviewer issue so much as an nbconvert one.

@rgbkrk
Copy link
Member

rgbkrk commented Dec 19, 2013

Ah, ok. That makes sense.

A lot of these issues seem to be nbconvert issues.

On a side note, it seems like nbviewer is always going to be the gateway to issues for nbconvert since this is the ipy in the sky.

Perhaps the error page should give people a simple way to run nbconvert on the notebook and write an issue within https://github.com/ipython/ipython.

@minrk
Copy link
Member

minrk commented Dec 19, 2013

500 errors are always nbviewer issues - that shouldn't happen. 'Wrong' rendering is typically nbconvert, and thus belongs at ipython proper. I don't think there's a problem pointing here by default, and then forwarding Issues to IPython when we know more about the culprit.

@damianavila
Copy link
Member

I don't think there's a problem pointing here by default, and then forwarding Issues to IPython when we know more about the culprit.

I agree...

@Carreau Carreau added the tag:Sprint Friendly A good issue to tackle during a sprint, hackathon, etc. label Sep 11, 2015
@parente
Copy link
Member

parente commented Jul 16, 2018

Updated ANSI Test.ipynb location for reference: http://nbviewer.jupyter.org/github/jupyter/notebook/blob/master/tools/tests/ANSI Test.ipynb

I believe the underline and bold examples are the only ones not working on nbviewer today based on my quick side-by-side comparison of that nbviewer link versus the same ipynb rendered by a local notebook server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:Sprint Friendly A good issue to tackle during a sprint, hackathon, etc. type:Bug An unexpected behavior
Projects
None yet
Development

No branches or pull requests

6 participants