1 for that...

I would be minus one for adding discussion / comments to nbviewer.

because...

Because I wouldn't want comments on my notebooks, and there is no logical mechanism for disabling them, because nbviewer has no notion of a 'post' - it is a weakref render of things that actually exist elsewhere on the internet. For instance, a gist already has comments, so it would be silly to have additional comments on nbviewer.

I think we should think about this - I can see that there might be a value
of providing comments. But there are many ways we could do this and I
would really want to get it right. I too am -1 on just adding discus at
this point.

On Wed, May 8, 2013 at 12:43 PM, Min RK [email protected] wrote:

Because I wouldn't want comments on my notebooks, and there is no logical
mechanism for disabling them, because nbviewer has no notion of a 'post' -
it is a weakref render of things that actually exist elsewhere on the
internet. For instance, a gist already has comments, so it would be silly
to have additional comments on nbviewer.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/80#issuecomment-17629116
.

Brian E. Granger
Cal Poly State University, San Luis Obispo
[email protected] and [email protected]

I would think a criterion for adding comments is adding the notion of authors and posts with control over these things (i.e. turning it into a complete blogging platform). That would be a totally different application than what we have now.

Because I wouldn't want comments on my notebooks, 

I can understand that... but I think some people like it very much...

and there is no logical mechanism for disabling them,     

thinking on the fly: a metadata flag (ie, no-comments) that could be read by nbviewer to , finally, not add the disqus machinery trough jinja templating.

because nbviewer has no notion of a 'post' - it is a weakref render of things that actually exist elsewhere on the internet. 

but can not be read it in gist form... you actually need to pass it over nbviewer to make comments... going out and going back to gist seems not straightforward to me...

I think, in general, for comments to make sense nbviewer needs to be a fundamentally different entity, with authors, ownership, and control of each notebook.

I would think a criterion for adding comments is adding the notion of authors and posts with control over these things (i.e. turning it into a complete blogging platform). That would be a totally different application than what we have now.

Just to add to the discussion, disqus provides a platform to moderate the post and you have to login (and then, have an ID) to make comments, so the author of the ipynb can get control over the comment on their notebooks.

I understand you thoughts in general, but I think comments it would be very valuable even in a some permissive and primary form.

Personally, I'm 👎 on this one for several reasons:

• This would add on yet another third party service to be relied on (which would affect other people installing nbviewer)
• Discussion of notebooks happens frequently outside of the notebooks themselves (twitter, gists, etc.)
• Discussion should be opt-in, not opt-out

This isn't to say that I'm not a fan of discussion. Quite the contrary. What I'm thinking is that this project should be pluggable enough that it does one thing really well and is extensible enough that people could run their own site with these types of features very easily.

What I'm thinking is that this project should be pluggable enough that it does one thing really well and is extensible enough that people could run their own site with these types of features very easily.

And probably, a lot of people will add this feature... because the people loves the discussion. So, making "extensible enough" makes me wonders if it would not be interesting to develop a platform inside nbviewer to add a sort of plugins or extensions infrastructure to make this things (like commentary) easy to plug-in...

I was thinking more like you use the handlers yourself and a lot of the machinery. Adding disqus would be the simple addition of a template and a configurable environment variable (or other way to configure it).

I was thinking more like you use the handlers yourself and a lot of the machinery.

OK...

Adding disqus would be the simple addition of a template and a configurable environment variable (or other way to configure it).

Yep

Or, notebook authors could just go ahead and do it, as @tonyfast has here.

Wrapped in a small magic, this would not actually be that bad for daily use. Nbviewer as blog engine :)

There's a list of XSS exploits for other platforms as long as my arm, but our no-auth stance makes this actually not that bad.

Nice. I like that it can be done in the notebook, without being on by default. We could even shorthand that with a metadata key for simpler opt-in.

As long as we stick with a no-auth stance, I'm happy to leave nbviewer as a free-for-all anything-goes JS XSS battleground playground. The battle between potentially allowing private anything held me back in the past.

Or, notebook authors could just go ahead and do it, as @tonyfast has here.

And it is a natural response...

Nice. I like that it can be done in the notebook, without being on by default. We could even shorthand that with a metadata key for simpler opt-in.

If I have to choose, I will setup disqus in nbviewer itself (in our own templates) and ask people for the meta key for activation and a meta key with maybe the disqus user)...

BTW, eventually we need to provide a better way to include metadata in the notebook (the current mini-editor is very prone to input errors). Maybe a magic to write in the notebook metadata could be an option.

Let's put this on the agenda for the week...

On Sat, Jun 6, 2015 at 4:24 AM, Damián Avila [email protected]
wrote:

Or, notebook authors could just go ahead and do it, as @tonyfast
https://github.com/tonyfast has here.

And it is a natural response...

Nice. I like that it can be done in the notebook, without being on by
default. We could even shorthand that with a metadata key for simpler
opt-in.

If I have to choose, I will setup disqus in nbviewer itself (in our own
templates) and ask people for the meta key for activation and a meta key
with maybe the disqus user)...

BTW, eventually we need to provide a better way to include metadata in the
notebook (the current mini-editor is very prone to input errors). Maybe a
magic to write in the notebook metadata could be an option.

—
Reply to this email directly or view it on GitHub
#80 (comment).

Brian E. Granger
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
[email protected] and [email protected]

I always hoped the notebook metadata could be edited with YAML. It is great for configurations.

Hi guys, I have made a python package to add Disqus to your Jupyter Notebook. Check out https://github.com/vwxyzjn/jupyter_disqus