-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual error messages cause confusion #136
Labels
Comments
👍 to removing error data from execute_reply in the next revision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When there's an error, the kernel is supposed to send both an
error
message on iopub, and an execute_reply with largely the same contents on the shell channel. This feels redundant, and it's easy to miss one out without causing enough problems to notice - issue takluyver/bash_kernel#44 is because bash_kernel was only sending the error data in anexecute_reply
message, and that had gone unnoticed until now.When we get round to making the next major version of the message protocol, I'd like to simplify this to make it more obvious. I might remove the error data from
execute_reply
, so it just contains'status': 'error'
, and theerror
message has to be used for the details of what went wrong.The text was updated successfully, but these errors were encountered: