Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test for nested source folder #57

Merged
merged 1 commit into from
Dec 16, 2020
Merged

test for nested source folder #57

merged 1 commit into from
Dec 16, 2020

Conversation

vidartf
Copy link
Collaborator

@vidartf vidartf commented Dec 15, 2020 •
edited
Loading

If I understood #50 correctly, this test should cover the case mentioned in the description. I do not know if the issue was fixed elsewhere, or if the test is "wrong", but it seems to pass as it is?

blink1073
blink1073 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit d859390 into jupyter:master Dec 16, 2020
@vidartf vidartf deleted the nested branch December 18, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vidartf @blink1073