Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling of data_files in develop mode and add test #35

Merged
merged 5 commits into from
May 26, 2020
Merged

Add handling of data_files in develop mode and add test #35

merged 5 commits into from
May 26, 2020

Conversation

blink1073
Copy link
Contributor

Fixes #34

@blink1073 blink1073 added this to the 0.5 milestone May 25, 2020
afshin
afshin approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blink1073 blink1073 merged commit bd23e9d into jupyter:master May 26, 2020
@SylvainCorlay
Copy link
Member

This is a brilliant solution. Thanks!

@Zsailer Zsailer mentioned this pull request Jun 11, 2020
Merged
@blink1073 blink1073 mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afshin afshin afshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

Add support for data_files in develop mode
3 participants
@blink1073 @SylvainCorlay @afshin