Make callsign function accept messages as bytes.
#67
Conversation
The pyModeS accepts messages in hex string format only. The change allows the pyModeS API to accept messages in binary format also. Once all functions are changed to accept both message formats, the internals of pyModeS can be flipped to use binary data. This, hopefully, will make the library bit faster for applications processing binary messages only.
|
The thing with your implementation is that it breaks the basic test: pms.adsb.callsign(b"8D406B902015A678D4D220AA4BDA")(The compiled version works based on this assumption, even though the tests do not reflect this) Maybe we need to distinguish both bytes representations. |
|
Well, if we want to support real binary data, then hex string as bytes type will be hard to distinguish from its real binary representation. I will just repeat my argument from #61 - it is more efficient to store binary version of ADS-B messages. Having that, conversion by pyModeS Also, I can see that |
|
I understand your point, it sounds valid. I am not saying it should be ignored. There is performance, poor choices made in the past, and also backward compatibility to keep in mind. Maybe I'll leave it to @junzis, he is the boss here, but I think we should keep your comment in mind when refactoring the whole set of core functions for v3. |
|
I used I am not saying this is the best option, but it has the best compatibility. Hey guys, pyModeS was from Python 2 time. Probably there are still some Python 2 pyModeS users out there. :) However, I completely agree with @xoolive. Such change has to be done once for all, preferably in a major update later. We also need to be able to support both So, for the moment, I prefer to wait and give it some more thoughts from my side. I will keep you guys updated. |
|
No worries, just wanted to propose something constructive in the context of #61. |
|
Regarding Python 2, it is worth considering https://pythonclock.org/ and https://python3statement.org/, I believe. |
The pyModeS accepts messages in hex string format only. The change
allows the pyModeS API to accept messages in binary format also.
Once all functions are changed to accept both message formats, the
internals of pyModeS can be flipped to use binary data. This, hopefully,
will make the library bit faster for applications processing binary
messages only.
See also discussion in #61.