-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate images error #2
Comments
Hi, unfortunately, I'm not able to replicate this error. Can you provide any additional information about when this took place? Also, apologies for the late reply. Thanks for using this project! |
Looks like the json decode error has been fixed, now I'm getting endless Looks like the same as #3 |
Thanks for mentioning this, those are definitely the same issue. The problem is probably the GitHub statistics API. For more information see this note in the API docs. To summarize that documentation: the API takes a long time to assemble some repo statistics, and doesn't know how long this operation will take, so it just indefinitely returns 202s unless a repo has cached statistics. If there are lots of repos with complex statistics that aren't cached, it will take a very long time (as you have seen first-hand), even with 10 asynchronous connections. I'm not totally sure why this originally eventually failed with an error, but I don't actually think the error is the heart of the problem – I think working around the limitations of the API with regards to timing will and avoid the complicated issue of replicating the code failure directly. That being said, I've been meaning to push a workaround to this, but have been way too busy for the last little while. I think adding a timeout would be beneficial, even though it would mean that the resulting traffic statistics would be incomplete. |
Didn't mean to close this. Apparently putting "Fix #2" in the commit message auto-closes an issue. I just pushed something I hope will fix the issue, but I am not totally sure. To be precise: I changed the infinite loop that generates all of the 202s into a loop with a max number of tries that returns incomplete data as a fallback. Please merge the change into your fork and see if it works better. |
I pushed some fixes that seem to have resolved #3. Please merge the fixes, and if it works for you, I will close this issue. |
Awesome, looks like that worked |
I am also getting this error/warning message:
However the action does not fail, should I be worried? |
@yooksi this is normal, and is part of GitHub's API response related to caching. It shouldn't significantly impact the output statistics, nor should it cause any fatal errors in the workflow. |
Getting this error:
The text was updated successfully, but these errors were encountered: