Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move wasCommonJS function out of resolver and into a provider hook #242

Open
Bubblyworld opened this issue Feb 28, 2023 · 2 comments
Open

Move wasCommonJS function out of resolver and into a provider hook #242

Bubblyworld opened this issue Feb 28, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Bubblyworld
Copy link
Contributor

Currently the resolver supports checking if a module was transpiled to ESM from CJS by seeing if it has an export with a modulename!cjs subpath. Adding these exports is something only the jspm.io CDN does, I think, so we should probably move it out of the main logic and into the jspm.io provider.
@Bubblyworld Bubblyworld added the enhancement New feature or request label Feb 28, 2023
@Bubblyworld
Copy link
Contributor Author

See https://github.com/jspm/generator/blob/main/src/trace/resolver.ts#L301

@guybedford
Copy link
Member

Definitely sounds worthwhile to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guybedford @Bubblyworld