Feature/fix issue 1364 #1365
Merged
Feature/fix issue 1364 #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
germanbisurgi
commented
Jul 3, 2023
germanbisurgi
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| Is backward-compatible? | ✔️ |
| Tests pass? | ✔️ |
| Fixed issues | #1364 |
| Added CHANGELOG entry? | ✔️ |
…sing dependencies. Registering the editor before setting the initial values allows for better communication between editors when using dependencies
schmunk42
approved these changes
Jul 3, 2023
YuriHeupa
reviewed
Sep 27, 2023
| @@ -1109,6 1109,7 @@ export class ObjectEditor extends AbstractEditor { | |||
|
|
|||
| Object.keys(this.editors).forEach(i => { | |||
| if (this.editors[i].isActive()) { | |||
| this.editors[i].refreshValue() | |||
There was a problem hiding this comment.
For some reason after this change was introduced, the disable_array_delete_all_rows/disable_array_delete_last_row options stopped working as expected. When the editor loads a schema with empty initial data for an array, the "delete all row" and "delete last row" buttons are always visible. Reverting this line change seems to fix the issue. Additionally, adding and then removing a row also causes the buttons to disappear.
There was a problem hiding this comment.
Could you create an issue with an example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.