Fix strict concurrency warnings #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @kevin-kp! Great work 💯 couple Qs for you - (caveat - I haven"t dived into Regarding JSONEncoder - would a |
|
LGTM - feel free to change from Draft to Open and I"ll approve |
# Conflicts: # Papyrus/Sources/PapyrusRequest.swift # Papyrus/Sources/PapyrusResponse.swift
|
@joshuawright11 it actually isn"t ready yet as the Provider is still not Sendable (which i"m currently getting warnings from). |
|
@joshuawright11 sorry for the delay, I had doubts of making provider an actor so I created a mutex instead. |
kevin-kp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an effort to fix the strict concurrency warnings when adding the swift setting
StrictConcurrency(not included in the commit).You can test this by adding the following to the necessary targets:
The only two warnings that are left are
HTTPBodyEncoderandHTTPBodyDecoder.This is because Sendable conformance is iOS >= 16.0 for JSONEncoder and JSONDecoder and I"m not sure what the best approach is to resolve these two warnings.