Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for movie when adding to Radarr list #8

Merged
merged 2 commits into from
Jun 29, 2017
Merged

Search for movie when adding to Radarr list #8

merged 2 commits into from
Jun 29, 2017

Conversation

hackworth
Copy link
Contributor

Fixes issue #7

@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8    /-   ##
=======================================
  Coverage   78.37%   78.37%           
=======================================
  Files          16       16           
  Lines         222      222           
=======================================
  Hits          174      174           
  Misses         48       48
Impacted Files Coverage Δ
src/api/radarr.js 9.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a31f7e...dd55f8a. Read the comment docs.

josephschmitt
josephschmitt previously approved these changes Jun 29, 2017
Copy link
Owner

@josephschmitt josephschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should set this for Sonarr too? Does it make sense there?

@josephschmitt
Copy link
Owner

Mind bumping the version number to 1.1.8 in the package json? Then run npm insall one more time so it updates the package-lock file, and add both those files to this PR. Then I can merge.

@hackworth
Copy link
Contributor Author

npm install didn't update the package-lock file automatically, so I updated both manually.

Sonarr automatically searches so this isn't needed there.

@josephschmitt
Copy link
Owner

👍

@josephschmitt josephschmitt merged commit 2c9bc28 into josephschmitt:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants