Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Painters! #55

Open
jogboms opened this issue Aug 17, 2019 · 5 comments
Open

Custom Painters! #55

jogboms opened this issue Aug 17, 2019 · 5 comments
Assignees
@jogboms @aagarwal1012
Labels
breaking-change enhancement New feature or request help wanted Extra attention is needed
Milestone
v6.0.0

Comments

@jogboms
Copy link
Owner

jogboms commented Aug 17, 2019

Planning on a complete rewrite from animated Widgets to CustomPaints. I believe this would have some improved performance. Anyone can help out if need be.
@jogboms jogboms added enhancement New feature or request help wanted Extra attention is needed labels Aug 17, 2019
@jogboms jogboms added this to the v5.0.0 milestone Aug 17, 2019
@aagarwal1012
Copy link
Collaborator

@jogboms, it seems like a nice plan.

@jogboms
Copy link
Owner Author

jogboms commented Aug 17, 2019

It will take some amount of effort too 👍

@jogboms jogboms pinned this issue Aug 18, 2019
@masashi-sutou masashi-sutou mentioned this issue Dec 9, 2019
Closed
@payam-zahedi
Copy link
Contributor

Hi @jogboms , if it's possible I want to work on it.
And my question is what should happen to the itemBuilder parameter?
should we remove it or anything else?

@jogboms
Copy link
Owner Author

jogboms commented Feb 13, 2020

Hey @payam-zahedi

I really haven't given it too much thought as I would want it to be as clean and extendable as it can be with every information we have gathered so far.

Hoping one day, I'd have a free couple of day to give it the first push. I wouldn't mind if you do and then we review and extend it together. I have delayed for too long now indeed.

@jogboms
Copy link
Owner Author

jogboms commented May 23, 2020

I should have added this earlier. As @payam-zahedi mentioned, in order to remove the use of composed widgets, we would have to let go of the itemBuilder parameter. I don't know how the community would feel about this as I know the feature was requested and its been used already by many.

@jogboms jogboms mentioned this issue May 27, 2020
Closed
@jogboms jogboms linked a pull request May 29, 2020 that will close this issue
Integrate some widgets with painter #79
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jogboms jogboms

@aagarwal1012 aagarwal1012

Labels
breaking-change enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

Integrate some widgets with painter
3 participants
@jogboms @aagarwal1012 @payam-zahedi