Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externalize Dockfile contents? #6

Closed
purplecones opened this issue Jan 15, 2017 · 9 comments
Closed

externalize Dockfile contents? #6

purplecones opened this issue Jan 15, 2017 · 9 comments

Comments

@purplecones
Copy link
Collaborator

No description provided.

@purplecones
Copy link
Collaborator Author

Provide ability to override default Dockerfile with a user provided one? Perhaps we can look for a Dockerfile in the Meteor dir and use that if it exists, otherwise use the our default one.

@purplecones
Copy link
Collaborator Author

This just provides additional complexity thats not necessary. Either way, the process needs our custom Dockerfile to properly run on the free plan. Closing issue. We can explore down the road again.

@emilbruckner
Copy link

I love meteor-now, but can't use it with one app, which needs Imagemagick and some other node version
Support for a custom Dockerfile would be highly appreciated
The splitting is a good hack, so without adding much complexity, I could also think of adding flags for choosing a node version and adding Imagemagick (I don't know how frequently it is used, but there are Images on Docker Hub supporting it)
But copying and editing a Dockerfile also isn't too hard …

@jkrup
Copy link
Owner

jkrup commented Jan 22, 2017

@emilbruckner good to know, we could look into allowing a custom Dockerfile.

For now it's definitely not hard for us to allow specifying NODE. Could you give me some details about what your using for imagemagick?

Do you know if all you'd need in the dockerfile is a RUN apt-get install imagemagick? If so maybe we could support passing in a list of packages which we would run apt-get install in?

@jkrup jkrup reopened this Jan 22, 2017
@emilbruckner
Copy link

I use meteor/cfs:graphicsmagick for Imagemagick. RUN apt-get install imagemagickdoes what I need. Passing in a list sounds like an option, but I don't know what others would use it for …

@jkrup
Copy link
Owner

jkrup commented Feb 22, 2017

Hey @emilbruckner you should be able to run meteor-now --dependencies imagemagick and deploy your app with meteor-now. Please let me know if that's working for you. (You will need to npm install -g [email protected] first)

@emilbruckner
Copy link

@mazlix yes, works perfectly! thanks

@alimgafar
Copy link

Is this still an open issue? @jkrup @purplecones

@jkrup jkrup closed this as completed Aug 31, 2017
@vladejs
Copy link

vladejs commented Apr 1, 2019

What about globally installed npm modules?

My use case is phantomjs, which is used by html-pdf library which assumes phantomjs is installed globally.

I don't know how to instruct the docker file to npm i -g phantomjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants