This repository has been archived by the owner on Feb 12, 2021. It is now read-only.
Enable/disable portable mode setting #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjw24
changed the title
jjw24
changed the title
- add message to inform user - create uninstaller entry - set delete indication
.dead file add
Added const for deletion indicator
Make intentions clearer
Should be handled somewhere else
theClueless
suggested changes
Mar 14, 2020
|
@theClueless please review |
theClueless
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
I want to be able to change Wox to portable mode, which means I can drop it in my dropbox/cloud provider/roaming profile etc and be able to use it when I download/open it in another computer/VM with all my settings intact(except for Folder plugin's folder paths).
Solution:
Expected code behaviour:
Check if user's data is in both roaming and portable location, this can happen if user forgets to delete one of them previously when manually enabling portable mode.
Create/Delete shortcuts to Wox.exe
Create/Delete uninstaller entry to Wox.exe
Copy user's data to the corresponding mode's data location
Mark which user data location is to be deleted
Prompt the user to let them know restart is required and restart automatically
Delete the old user data location that is marked to be deleted
User interface:
Trigger from settings portable/installed mode via clicking on check box
Wox is restarted automatically
