Fix asciidoc figure with empty title #10047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies! I didn't notice that this was a pull request -- I took it to be an issue, and I fixed it myself. Your PR was perfectly good, though. I'm sorry for not noticing that. |
|
LMAO. No problem at all. I started writing an issue but looked at the code and figured it's this simple, so the description very much reads like an issue at the first glace. Anyway, thank you for such quick response and glad it's fixed :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this when converting from docbook's
informalfigure(that is a figure without a title) to asciidoc.For this input presented as example in docbook docs
the output includes extra leading
.that would precede a title but is invalid alone.. image::watarun.eps[watarun]In this PR I added a simple if check for empty title so it correctly outputs
image::watarun.eps[watarun]