default.latex: wrong beamer color in (sub)section page #10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks great! Only thing is to reformat the commit message so that the lines are not more than 80 characters wrong (hard wrap). That makes it easier when it comes time to make a changelog. See CONTRIBUTING.md under Pull Requests. |
jdgx
force-pushed
the
fix-beamercolorbox-for-sections
branch
2 times, most recently
from
23d53e8
to
d1c47e3
Compare
The default.latex template defines "part title", "section title" and "subsection title" via \setbeamertemplate. But for "section title" and "subsection title", the beamercolorbox also used the "part title" parameter instead of the "(sub)section title". This had the effect that for (sub)section pages the color attributes of the part title were used.
jdgx
force-pushed
the
fix-beamercolorbox-for-sections
branch
from
d1c47e3
to
9c97112
Compare
|
Ok, the commit message is now fixed. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default.latex template defines "part title", "section title" and "subsection title" via \setbeamertemplate. But for "section title" and "subsection title", the beamercolorbox also used the "part title" parameter instead of the "(sub)section title". This had the effect that for (sub)section pages the color attributes of the part title were used instead of the ones for (sub)section title.
PS: It's my first pull request, please let me know if I'm doing something wrong or against good practice. I wasn't sure if I should open an issue first (or in addition to the pull request). Since this fix seems quite trivial, I just created the pull request.
Best,
Jonathan