Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve template names and line numbers in error messages #53

Open
jg-rp opened this issue Apr 22, 2022 · 1 comment
Open

Improve template names and line numbers in error messages #53

jg-rp opened this issue Apr 22, 2022 · 1 comment
Labels
version 2 Fix or include in version 2 of Python Liquid

Comments

@jg-rp
Copy link
Owner

jg-rp commented Apr 22, 2022 •
edited
Loading

While Python Liquid's error messages do contain template names and offending line numbers where possible, there is room for improvement, especially for expressions that span multiple lines.

The error message format implemented in LiquidScript seems more readable, and LiquidScript keeps track of the starting index of each token in template source text, rather than a line number, resulting in more accurate error messages.
@jg-rp jg-rp added the version 2 Fix or include in version 2 of Python Liquid label Apr 22, 2022
@janwirth
Copy link

I consider chumsky / ariadne error reporting for parser to be the best out there right now:
https://github.com/zesterer/chumsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
version 2 Fix or include in version 2 of Python Liquid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@janwirth @jg-rp