Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment tag parsing #133

Open
jg-rp opened this issue Nov 29, 2023 · 0 comments
Open

Comment tag parsing #133

jg-rp opened this issue Nov 29, 2023 · 0 comments
Labels
enhancement New feature or request future Fixes to be included in the 'future' environment version 2 Fix or include in version 2 of Python Liquid

Comments

@jg-rp
Copy link
Owner

jg-rp commented Nov 29, 2023

Shopify/liquid have changed comment tag parsing behaviour. Other than {% raw %} tags, all valid and invalid tags inside a comment block are now not parsed, whereas before they were, potentially causing errors from ill formed tags inside the comment block.

This new behaviour is close to Python Liquid’s default behaviour, with the exception that Shopify/Liquid now allows any number of fully-formed nested comment blocks, which causes a LiquidSyntaxError in Python Liquid.

We should include an implementation of the comment tag that matches Shopify/liquid and use it as the default in liquid.future.Environment.

@jg-rp jg-rp added enhancement New feature or request future Fixes to be included in the 'future' environment labels Nov 29, 2023
@jg-rp jg-rp added the version 2 Fix or include in version 2 of Python Liquid label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request future Fixes to be included in the 'future' environment version 2 Fix or include in version 2 of Python Liquid
Projects
None yet
Development

No branches or pull requests

1 participant