Enhancement: Additional CLI options to control rendered output -label-edges #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2019 23:40
…-edges Fixes #58 In implementing this, I decided to use the -show-connection-labels for consistency with other flags. I also realized that the SetRenderingOptions what going to be a problem for testing so I changed its parameter to be a map[RenderingOption] bool where the RenderingOption is no more than an int for which we have provided a set of constants. I also updated the Readme and the class diagram to reflect this new options.
Codecov Report
@@ Coverage Diff @@
## master #73 /- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 496 526 30
=====================================
Hits 496 526 30
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
In implementing this, I decided to use the -show-connection-labels for consistency with other flags. I also realized that the SetRenderingOptions what going to be a problem for testing so I changed its parameter to be a map[RenderingOption] bool where the RenderingOption is no more than an int for which we have provided a set of constants.
I also updated the Readme and the class diagram to reflect this new options.