Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not launching in Korean environment with default language: 'auto' config #3743

Closed
floydkim opened this issue Jul 13, 2024 · 2 comments · Fixed by #3744
Closed

Not launching in Korean environment with default language: 'auto' config #3743

floydkim opened this issue Jul 13, 2024 · 2 comments · Fixed by #3744
Labels
bug Something isn't working

Comments

@floydkim
Copy link

Describe the bug

After upgrading to version 0.43.0, lazygit does not launch with the default language setting ‘auto’.

I have resolved the issue temporarily by setting the language to 'ko' or 'en' in the config file as follows:

gui:
    language: ko

(config file : ~/Library/Application\ Support/lazygit/config.yml)

To Reproduce

  1. Install lazygit 0.43.0 (using homebrew)
  2. Open a terminal and run lazygit.

error

2024/07/13 16:35:26 open translations/ko-KR.json: file does not exist

Expected behavior

lazygit should launch.

Screenshots

image

Version info:
Run lazygit --version and paste the result here

commit=, build date=, build source=homebrew, version=0.43.0, os=darwin, arch=arm64, git version=2.39.3 (Apple Git-146)

Run git --version and paste the result here

git version 2.39.3 (Apple Git-146)

Additional context
Add any other context about the problem here.

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.
@floydkim floydkim added the bug Something isn't working label Jul 13, 2024
@stefanhaller stefanhaller mentioned this issue Jul 13, 2024
Merged
@stefanhaller
Copy link
Collaborator

Thanks for the report, what a stupid bug. Here's a fix: #3744

stefanhaller added a commit that referenced this issue Jul 13, 2024
@stefanhaller
Fix language auto detection (#3744)
71ad3fa 
- **PR Description**

Fix a regression (introduced with #3649) that broke language
auto-detection. When starting lazygit with the `gui.language` config set
to "auto" (which is the default), lazygit would fail to start if the
LANG environment is set to one of our supported languages.

For example:
```
$ export LANG=nl_NL
$ lazygit
2024/07/13 11:43:03 open translations/nl-NL.json: file does not exist
```

Fixes #3743
@floydkim
Copy link
Author

it's fixed and working well. thank you so much 😄 @stefanhaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix language auto detection jesseduffield/lazygit
2 participants
@stefanhaller @floydkim