Merge pull request ioncodes#9 from Plutoberth/saveOnExecute

Save files on execution with a config setting
jespanag · Jul 4, 2020 · 15b9672 · 15b9672
2 parents f0e64b0 975ac74
commit 15b9672
Show file tree

Hide file tree

Showing 7 changed files with 29 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -66,4 66,5 @@ It is also important that attaching a debugger will create a new debugger instan
 
 ## Contributors
 * [mrexodia](https://github.com/mrexodia)
-* [MeitarR](https://github.com/MeitarR)
 * [MeitarR](https://github.com/MeitarR)
 * [Plutoberth](https://github.com/Plutoberth)
diff --git a/ida/idacode_utils/plugin.py b/ida/idacode_utils/plugin.py
@@ -10,7 10,7 @@
 import idacode_utils.settings as settings
 from idacode_utils.socket_handler import SocketHandler
 
-VERSION = "0.1.3"
 VERSION = "0.1.4"
 initialized = False
 
 def setup_patches():

diff --git a/idacode/CHANGELOG.md b/idacode/CHANGELOG.md
@@ -17,4 17,8 @@
 
 ### 0.1.3
 
-- Added support for Python 2
 - Added support for Python 2
 
 ### 0.1.4
 
 - Added "Save on execute" support in settings
diff --git a/idacode/README.md b/idacode/README.md
@@ -54,4 54,8 @@ IDACode doesn't support host to VM communication unless the VM uses a shared vol
 
 ### 0.1.3
 
-- Added support for Python 2
 - Added support for Python 2
 
 ### 0.1.4
 
 - Added "Save on execute" support in settings
diff --git a/idacode/package-lock.json b/idacode/package-lock.json
diff --git a/idacode/package.json b/idacode/package.json
@@ -3,7 3,7 @@
  "displayName": "IDACode",
  "description": "Run and debug your IDA scripts from VS Code",
  "icon": "images/icon.png",
- "version": "0.1.3",
  "version": "0.1.4",
  "publisher": "Layle",
  "license": "SEE LICENSE IN LICENSE.md",
  "preview": true,
@@ -71,6 71,11 @@
  "type": "integer",
  "default": 7066,
  "description": "The port the IDA debug server is listening on."
  },
  "IDACode.saveOnExecute": {
  "type": "boolean",
  "default": true,
  "description": "Save all open editors when executing."
  }
  }
  }

diff --git a/idacode/src/extension.ts b/idacode/src/extension.ts
@@ -15,7 15,7 @@ function getCurrentDocument(): string {
  return vscode.window.activeTextEditor?.document.uri.fsPath as string;
 }
 
-function executeScript() {
 function executeScriptInIDA() {
  const currentDocument = getCurrentDocument();
  const name = path.parse(currentDocument).base;
  socket.send({
@@ -25,6 25,14 @@ function executeScript() {
  vscode.window.showInformationMessage(`Sent ${name} to IDA`);
 }
 
 function executeScript() {
  if (getConfig<boolean>('saveOnExecute')) {
  vscode.workspace.saveAll().then(executeScriptInIDA);
  } else {
  executeScriptInIDA();
  }
 }
 
 function connectToIDA() {
  return new Promise((resolve, reject) => {
  const host = getConfig<string>('host');